Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: refactored vmargs to accept a vector array #4822

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

mohanson
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

The current approach completely prohibits the possibility of receiving external arguments to initialize the VM stack, which has led to the breakdown of some important functions in the ckb-debugger.

What is changed and how it works?

Use an enumeration type to represent the type of the parameter.

  • VmArgs::Reader(u64, u64, u64) == Some((u64, u64, u64))
  • VmArgs::Vector(vec![]) == None
  • VmArgs::Vector(vec!["a", "b", "c"]) : The new method for ckb-debugger

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • No code ci-runs-only: [ quick_checks,linters ]

Release note

None: Exclude this PR from the release note.

@mohanson mohanson requested a review from a team as a code owner February 26, 2025 06:48
@mohanson mohanson requested review from doitian and removed request for a team February 26, 2025 06:48
@mohanson
Copy link
Contributor Author

cc @xxuejie

@eval-exec eval-exec added the m:vm label Feb 26, 2025
eval-exec
eval-exec previously approved these changes Feb 26, 2025
zhangsoledad
zhangsoledad previously approved these changes Feb 26, 2025
@mohanson mohanson dismissed stale reviews from zhangsoledad and eval-exec via 0dcf7dc February 26, 2025 08:34
@zhangsoledad zhangsoledad merged commit 8444466 into nervosnetwork:develop Feb 26, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants