script: refactored vmargs to accept a vector array #4822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
The current approach completely prohibits the possibility of receiving external arguments to initialize the VM stack, which has led to the breakdown of some important functions in the ckb-debugger.
What is changed and how it works?
Use an enumeration type to represent the type of the parameter.
VmArgs::Reader(u64, u64, u64) == Some((u64, u64, u64))
VmArgs::Vector(vec![]) == None
VmArgs::Vector(vec!["a", "b", "c"]) : The new method for ckb-debugger
Related changes
owner/repo
:Check List
Tests
Release note